Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): showcase user QA-Board #3232

Merged
merged 3 commits into from
Aug 7, 2020
Merged

Conversation

arthur-flam
Copy link
Contributor

@arthur-flam arthur-flam commented Aug 7, 2020

Motivation

Hi,

We are working on a run-tracking framework for algo/perf engineering. We're using Docusaurus v2, and we're very happy about it. Thanks a lot for this project! I'm very impressed by how easy it is to get started, the number of features and how good it looks.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

I ran the updated website and the showcase is updated with all links OK.

Related PRs

Not relevant.

@arthur-flam arthur-flam requested a review from yangshun as a code owner August 7, 2020 07:33
@facebook-github-bot
Copy link
Contributor

Hi @arthur-flam!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Aug 7, 2020

Deploy preview for docusaurus-2 ready!

Built with commit adec6fb

https://deploy-preview-3232--docusaurus-2.netlify.app

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see a Samsung customer!

@yangshun
Copy link
Contributor

yangshun commented Aug 7, 2020

@arthur-flam please sign the CLA. If you've done so, it's all good and we just need to wait for the bot to update this PR.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 7, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@yangshun yangshun merged commit be210a1 into facebook:master Aug 7, 2020
@arthur-flam
Copy link
Contributor Author

Nice to see a Samsung customer!

Very happy one 😄

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants